NethCTI 3: reload doesn't work anymore

[Stell0]

CTI implements reload, that is called from systemd unit launcing a SIGUSR1:

ExecReload=/bin/kill -SIGUSR1 $MAINPID

but since last version it is broken, because nethcti-server is launched now using SCL: nethesis/nethcti-server@697f997#diff-fc64ba2de59129244f02959218e85b18
Now, $MAINPID has SCL PID(32478 in this example):

# ps aux | grep [n]ode
asterisk 32478  0.0  0.0   4352   584 ?        Ss   19:44   0:00 /usr/bin/scl enable rh-nodejs10 node /usr/lib/node/nethcti-server/nethcti.js
asterisk 32483  1.2  4.2 885084 65236 ?        Sl   19:44   0:08 node /usr/lib/node/nethcti-server/nethcti.js

When SIGUSR1 arrive to scl, it dies killing its child.

Additional informations:

• CTI doesn't have a PID file
• it should be possible to load SCL environment like we have done for asterisk: https://github.com/NethServer/nethserver-freepbx/blob/master/root/usr/lib/systemd/system/asterisk.service
• another possible solution is to call reload with

ExecReload=/usr/bin/pkill -SIGUSR1 -f -u asterisk '^node /usr/lib/node/nethcti-server/nethcti.js$'

this is tested and actually works, but is inelegant

• Another possible solution suggested by @DavidePrincipi is to create a bash wrapper that load scl environment, fork, setsid() and chdir()

[alepolidori]

How to test

• use systemctl reload nethcti-server
• verify that the server reloads also looking at /var/log/asterisk/nethcti.log

[nethbot]

in 7.6.1810/nethesis-testing:

• nethcti-server3-3.10.1-1.4.g81a2063.ns7.x86_64.rpm x86_64
• nethcti-server3-debuginfo-3.10.1-1.4.g81a2063.ns7.x86_64.rpm x86_64

[nethbot]

in 7.6.1810/nethesis-updates:

• nethcti-server3-3.11.0-1.ns7.x86_64.rpm x86_64
• nethcti-server3-debuginfo-3.11.0-1.ns7.x86_64.rpm x86_64