Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceConfiguration] enabled vs disabled #29

Closed
nemesifier opened this issue Sep 25, 2015 · 0 comments
Closed

[DeviceConfiguration] enabled vs disabled #29

nemesifier opened this issue Sep 25, 2015 · 0 comments
Assignees
Milestone

Comments

@nemesifier
Copy link
Member

Currently we have one attribute called enabled, while we have a few other ones called disabled.

It would probably be better to be consistent and chose one of the two.

I would prefer that if a block if present is enabled by default but can be disabled by adding { "disabled": true } if needed. It's easy to read and handy because it allows to temporarily disable a config block without removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant