New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL requirement and allow data to be passed as array or object #29

Open
ghost opened this Issue Aug 20, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Aug 20, 2016

Right now, you have your code written to require a URL, assuming that it's pulling a json file. Not everything is in a file, nor is it advantageous to have to write data out of a database into a file on every page load, so a front-end system can pick it up. It's feasible that the data has already been passed to the front end and ready for use by this. If I can pass a json object in instead of a URL then I'm happy. If I have to go through file IO, that kills performance, page load times, and UX experience.

@nemesisdesign

This comment has been minimized.

Show comment
Hide comment
@nemesisdesign

nemesisdesign Aug 23, 2016

Member

Pretty legitimate request, it shouldn't be hard to implement. I'm not working on this project actively right now, so I will implement this feature if I need it in the near future, or you can try to send a patch yourself.
Federico

Member

nemesisdesign commented Aug 23, 2016

Pretty legitimate request, it shouldn't be hard to implement. I'm not working on this project actively right now, so I will implement this feature if I need it in the near future, or you can try to send a patch yourself.
Federico

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 7, 2016

thanks!

ghost commented Nov 7, 2016

thanks!

@nemesisdesign

This comment has been minimized.

Show comment
Hide comment
@nemesisdesign

nemesisdesign May 31, 2017

Member

@geekplux this is also interesting, do you think we can do it?

Member

nemesisdesign commented May 31, 2017

@geekplux this is also interesting, do you think we can do it?

@geekplux

This comment has been minimized.

Show comment
Hide comment
@geekplux

geekplux Aug 20, 2017

Member

added a .load([data]) function.

Member

geekplux commented Aug 20, 2017

added a .load([data]) function.

@nemesisdesign

This comment has been minimized.

Show comment
Hide comment
@nemesisdesign

nemesisdesign Aug 24, 2017

Member

I just noticed that it is already possible to pass a javascript object instead of a URL, is just not clear from the code and documentation

Member

nemesisdesign commented Aug 24, 2017

I just noticed that it is already possible to pass a javascript object instead of a URL, is just not clear from the code and documentation

@geekplux

This comment has been minimized.

Show comment
Hide comment
@geekplux
Member

geekplux commented Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment