Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL requirement and allow data to be passed as array or object #29

Closed
ghost opened this issue Aug 20, 2016 · 6 comments
Closed

Comments

@ghost
Copy link

ghost commented Aug 20, 2016

Right now, you have your code written to require a URL, assuming that it's pulling a json file. Not everything is in a file, nor is it advantageous to have to write data out of a database into a file on every page load, so a front-end system can pick it up. It's feasible that the data has already been passed to the front end and ready for use by this. If I can pass a json object in instead of a URL then I'm happy. If I have to go through file IO, that kills performance, page load times, and UX experience.

@nemesifier
Copy link
Member

Pretty legitimate request, it shouldn't be hard to implement. I'm not working on this project actively right now, so I will implement this feature if I need it in the near future, or you can try to send a patch yourself.
Federico

@ghost
Copy link
Author

ghost commented Nov 7, 2016

thanks!

@nemesifier
Copy link
Member

@geekplux this is also interesting, do you think we can do it?

@geekplux
Copy link
Contributor

added a .load([data]) function.

@nemesifier
Copy link
Member

I just noticed that it is already possible to pass a javascript object instead of a URL, is just not clear from the code and documentation

@geekplux
Copy link
Contributor

@nemesisdesign I have updated README in dev branch. f8b49f1#diff-88b99bb28683bd5b7e3a204826ead112R212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants