Fix Squared Operator #1127
Merged
Fix Squared Operator #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
+ Coverage 81.66% 81.91% +0.25%
==========================================
Files 207 207
Lines 12543 12544 +1
Branches 1902 1903 +1
==========================================
+ Hits 10243 10276 +33
+ Misses 1854 1825 -29
+ Partials 446 443 -3
Continue to review full report at Codecov.
|
|
cool! was this affecting steady state solvers? |
gcarleo
approved these changes
Feb 28, 2022
femtobit
reviewed
Feb 28, 2022
|
Not really, it's just a factor of 2, but I'm trying to get those factors right. |
|
The steady state does not go through this code path (yet. I'll open another PR to do that, as this code path is simpler, cleaner and faster) |
nikosavola
pushed a commit
to nikosavola/netket
that referenced
this pull request
Jun 4, 2022
Cherry picked from netket#1065 so that i separate the two changes in two different PRs. Computing the gradient of operators that use nkjax.expect instead of the covariance formula (such as SquaredOperator) also had a wrong factor of 2 for C->C models. This is due to the weird way that Jax handles complex differentiation. This PR now fixes it, and a test is added to check the gradient wrt finite differences. Also, this PR moves out into a common test file the finite difference functions so that they can be used for other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #1065 so that i separate the two changes in two different PRs.
Computing the gradient of operators that use
nkjax.expectinstead of the covariance formula (such asSquaredOperator) also had a wrong factor of 2 for C->C models.This is due to the weird way that Jax handles complex differentiation.
This PR now fixes it, and a test is added to check the gradient wrt finite differences.
Also, this PR moves out into a common test file the finite difference functions so that they can be used for other tests.