Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfix in langevin sampler #1465

Merged
merged 1 commit into from Apr 24, 2023
Merged

Conversation

jwnys
Copy link
Collaborator

@jwnys jwnys commented Apr 24, 2023

Bug fixes to Langevin sampler:

  • when providing chunk_size != None, we got a tracing error
  • for some models the grad function failed due to a shape (1,)

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1465 (7c5c0f8) into master (aa2f609) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1465   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files         235      235           
  Lines       13542    13543    +1     
  Branches     2051     2052    +1     
=======================================
+ Hits        11325    11326    +1     
  Misses       1705     1705           
  Partials      512      512           
Impacted Files Coverage Δ
netket/sampler/rules/langevin.py 90.69% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PhilipVinc PhilipVinc merged commit 2f29c61 into netket:master Apr 24, 2023
9 checks passed
@PhilipVinc
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants