Reduce number of vjp calls in nk.jax.vjp for R->C functions #1681
+8
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
==========================================
- Coverage 82.37% 82.36% -0.02%
==========================================
Files 291 291
Lines 17801 17784 -17
Branches 3458 3456 -2
==========================================
- Hits 14664 14647 -17
Misses 2460 2460
Partials 677 677 ☔ View full report in Codecov by Sentry. |
|
Does this lead to a speedup? |
|
This should be throughly tested before merging. In limited testing on my laptop (though apple throttles aggressively, so should test on a cluster) I've seen no changes to slight performance degradation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed by some user on slack some time ago.
Might lead to some speedups, but unsure about that. Should benchmark.