Fix 1675 #1684
Merged
Fix 1675 #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(once we have consistent dtypes we can replace this with warnings and have the user set it reasonably)
PhilipVinc
approved these changes
Jan 8, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
+ Coverage 82.42% 82.56% +0.14%
==========================================
Files 293 293
Lines 18049 18049
Branches 3482 3482
==========================================
+ Hits 14876 14902 +26
+ Misses 2497 2472 -25
+ Partials 676 675 -1 ☔ View full report in Codecov by Sentry. |
jwnys
pushed a commit
to jwnys/netket
that referenced
this pull request
Jan 8, 2024
Make the "mask" implementation of FermiOperator2ndJax work with number of batch axes different from 1. Fixes netket#1675 (comment)). Also do some more casts to enforce the dtype of the configurations in the different implementations of the aforementioned operator, until one day we can set it consistently in e.g. hilbert.
jwnys
pushed a commit
to jwnys/netket
that referenced
this pull request
Jan 9, 2024
Make the "mask" implementation of FermiOperator2ndJax work with number of batch axes different from 1. Fixes netket#1675 (comment)). Also do some more casts to enforce the dtype of the configurations in the different implementations of the aforementioned operator, until one day we can set it consistently in e.g. hilbert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1675 (comment)
The extra two implementations are not currently tested (I did locally).
I also put some more casts to enforce the dtype of the configurations (until one day we can set it consistently in e.g. hilbert)