Fix 1726

[inailuig]

workaround for #1726

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f378bd4) 82.66% compared to head (8508d32) 82.67%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1727   +/-   ##
=======================================
  Coverage   82.66%   82.67%           
=======================================
  Files         298      298           
  Lines       18198    18200    +2     
  Branches     3473     3475    +2     
=======================================
+ Hits        15044    15046    +2     
  Misses       2476     2476           
  Partials      678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PhilipVinc]

I'm ok with this change. However are you sure that's the best approach instead of just jitting the method?

The only reason it is not jitted was to allow random rules to be implemented in numpy, but we are increasingly abandoning numpy and host callbacks are stable nowadays so in the future we could just jit as well.

[inailuig]

I'm ok with this change. However are you sure that's the best approach instead of just jitting the method?

No this is meant as a temporary fix until I do that in #1721, but it requires some changes to hilbert from this commit abba307 of #1720 to jit the whole thing (although #1721 already works).

[PhilipVinc]

ok, good thanks