Update to solve jax deprecations #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
===========================================
- Coverage 82.60% 51.74% -30.87%
===========================================
Files 309 309
Lines 18768 18192 -576
Branches 2757 2734 -23
===========================================
- Hits 15503 9413 -6090
- Misses 2581 8080 +5499
- Partials 684 699 +15 ☔ View full report in Codecov by Sentry. |
jwnys
pushed a commit
to jwnys/netket
that referenced
this pull request
Apr 23, 2024
Jax 0.4.25 deprecated `jax.tree_map` in favour of `jax.tree.map`. However `jax.tree.map` is only available in recent jax versions, so to avoid breaking older versions I replaced all usages of `jax.tree_map` with `jax.tree_util.tree_map`, which should be updated to `jax.tree.map` in a few months when we drop older jax versions. Documentation is updated to reflect latest jax versions, that is, `jax.tree.map`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax 0.4.25 deprecated
jax.tree_mapin favour ofjax.tree.map.However
jax.tree.mapis only available in recent jax versions, so to avoid breaking older versions I replaced all usages ofjax.tree_mapwithjax.tree_util.tree_map, which should be updated tojax.tree.mapin a few months when we drop older jax versions.Documentation is updated to reflect latest jax versions, that is,
jax.tree.map.