Fix gradients of variational states with complex parameters #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's amazing! I always suspected this . Thank you! Can you add a test that would otherwise fail, with mix ed parameters? |
inailuig
force-pushed
the
fix_grad_prefactor
branch
from
4300e88
to
4972d90
Compare
inailuig
force-pushed
the
fix_grad_prefactor
branch
2 times, most recently
from
b458d24
to
42848be
Compare
inailuig
force-pushed
the
fix_grad_prefactor
branch
from
42848be
to
7636bd6
Compare
inailuig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing factor 2 in force_to_grad for complex parameters.
We need to multiply the gradient of the complex parameters by 2, not only the real ones.
Otherwise the gradient is different between the complex-param model and the equivalent real one.
This in particular affects models with mixed real/complex parameters where so far the learning rate for the complex ones was half the learning rate of the real params.