Operators written purely in Jax #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcarleo
reviewed
Nov 3, 2021
| This rule only works with operators which are written in jax. | ||
| """ | ||
|
|
||
| def transition(self, _0, _1, _2, _3, key, x): |
There was a problem hiding this comment.
what are these 4 dummy arguments?
inailuig
commented
Nov 3, 2021
| This rule only works with operators which are written in jax. | ||
| """ | ||
|
|
||
| def transition(self, _0, _1, _2, _3, key, x): |
There was a problem hiding this comment.
Suggested change
| def transition(self, _0, _1, _2, _3, key, x): | |
| def transition(self, sampler, machine, parameters, state, key, x): |
PhilipVinc
reviewed
Sep 24, 2022
This was referenced Jun 28, 2023
PhilipVinc
added a commit
that referenced
this pull request
Jul 2, 2023
This is also a remanding of the original PR by @wdphy16 , following the new infrastructure for Jax-compatible operators. resuscitates #968 @wdphy16 as you are the original author of the code, could you please go back through it and comment it throughout? It's very complicated and it's very hard to follow what the generation of masks do... --------- authored-by: Clemens Giuliani <clemens@inailuig.it>
inailuig
added a commit
that referenced
this pull request
Jul 4, 2023
This is what is left of #968 rebased on master. --------- Co-authored-by: Filippo Vicentini <filippovicentini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the operators are written using numba for the very valid reason that the array shapes (number of connected elements) are in general data-dependent which is something not (yet?) supported by jax.
These operators can only be evaluated on the cpu, and are called either outside of a jax jit block or via numba4jax which has some overhead.
This PR adds a Ising operator with padding written in jax and a branchless, jax-jittable MetropolisSampler (I wanted some way to test the operator...) that runs fully on the gpu.
For Paulistrings the same can also be done easily (apart from the constructor).