Skip to content

Commit

Permalink
fix(flat-components): fix avatar show error (#1989)
Browse files Browse the repository at this point in the history
  • Loading branch information
syt-honey committed Aug 7, 2023
1 parent c65eb3f commit 3e33244
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import React, { useState } from "react";
import { MainPageLayoutItem } from "../types";

export interface MainPageNavAvatarProps {
userUUID: string;
/** user avatar src*/
avatarSrc: string;
/** user name */
Expand All @@ -20,6 +21,7 @@ export interface MainPageNavAvatarProps {
}

export const MainPageNavAvatar: React.FC<MainPageNavAvatarProps> = ({
userUUID,
avatarSrc,
userName,
onClick,
Expand All @@ -30,7 +32,7 @@ export const MainPageNavAvatar: React.FC<MainPageNavAvatarProps> = ({
const [popMenuVisible, setPopMenuVisible] = useState(false);
const [isAvatarLoadFailed, setAvatarLoadFailed] = useState(false);

const avatar = isAvatarLoadFailed ? generateAvatar(avatarSrc) : avatarSrc;
const avatar = isAvatarLoadFailed || !avatarSrc ? generateAvatar(userUUID) : avatarSrc;

const togglePopMenuVisible = (): void => {
setPopMenuVisible(!popMenuVisible);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export interface MainPageNavHorizontalProps extends MainPageNavAvatarProps, Main
}

export const MainPageNavHorizontal: React.FC<MainPageNavHorizontalProps> = ({
userUUID,
avatarSrc,
userName,
onClick,
Expand Down Expand Up @@ -101,6 +102,7 @@ export const MainPageNavHorizontal: React.FC<MainPageNavHorizontalProps> = ({
generateAvatar={generateAvatar}
popMenu={popMenu}
userName={userName}
userUUID={userUUID}
onClick={onClick}
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export interface MainPageTopBarProps extends MainPageNavAvatarProps {
}

export const MainPageTopBar: React.FC<MainPageTopBarProps> = ({
userUUID,
activeKeys,
avatarSrc,
popMenu,
Expand All @@ -36,6 +37,7 @@ export const MainPageTopBar: React.FC<MainPageTopBarProps> = ({
generateAvatar={generateAvatar}
popMenu={popMenu}
userName={userName}
userUUID={userUUID}
onClick={onClick}
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export const MainPageLayoutHorizontalContainer = observer<MainPageLayoutHorizont
subMenu={subMenu}
title={title}
userName={globalStore.userName ?? ""}
userUUID={globalStore.userUUID ?? ""}
onBackPreviousPage={onBackPreviousPage}
onClick={onMenuItemClick}
>
Expand Down

0 comments on commit 3e33244

Please sign in to comment.