Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion]: vite is ready for storybook? #1143

Closed
Tracked by #983
Cyberhan123 opened this issue Nov 25, 2021 · 13 comments
Closed
Tracked by #983

[discussion]: vite is ready for storybook? #1143

Cyberhan123 opened this issue Nov 25, 2021 · 13 comments
Assignees
Labels
stale Stale issues or PR

Comments

@Cyberhan123
Copy link
Contributor

Cyberhan123 commented Nov 25, 2021

In https://github.com/netless-io/telebox-insider vite is ready for storybook

@Cyberhan123 Cyberhan123 changed the title packages/flat-components [discussion]packages/flat-components Nov 25, 2021
@BlackHole1 BlackHole1 changed the title [discussion]packages/flat-components [discussion]: vite is ready for storybook Nov 26, 2021
@Cyberhan123
Copy link
Contributor Author

Is flat component need public storybook to somewhere?

@hyrious @BlackHole1

@hyrious
Copy link
Member

hyrious commented Nov 29, 2021

Is flat component need public storybook to somewhere?

Yes, at https://netless-io.github.io/flat.

@crimx May you have a look at storybook on vite?

@Cyberhan123
Copy link
Contributor Author

After my investigation last week, I found that the coexistence of vite and webpack is not a bad idea so far.

@Cyberhan123 Cyberhan123 changed the title [discussion]: vite is ready for storybook [discussion]: vite is ready for storybook? Nov 29, 2021
@crimx
Copy link
Member

crimx commented Nov 29, 2021

In https://github.com/netless-io/telebox-insider vite is ready for storybook

@Cyberhan123 Nice observation! Flat requires more features from storybook than telebox-insider which is still in development. We will migrate to storybook-builder-vite once storybookjs/builder-vite#2 (comment) is resolved.

@Cyberhan123
Copy link
Contributor Author

Let the bullet fly for a while,I will keep this issue,and provide a PR with [WIP] label

@hyrious
Copy link
Member

hyrious commented Nov 29, 2021

We also want to move to pnpm once storybookjs/storybook#13428 get resolved.

@stale
Copy link

stale bot commented Jan 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label Jan 28, 2022
@Cyberhan123 Cyberhan123 removed the stale Stale issues or PR label Jan 28, 2022
@Cyberhan123
Copy link
Contributor Author

We also want to move to pnpm once storybookjs/storybook#13428 get resolved.

The storybook plugin have an new version for suport react typescript, I'll try it soon.

@Cyberhan123
Copy link
Contributor Author

Synchronize the progress, I may need to fix this first

storybookjs/builder-vite#233 (comment)

@stale
Copy link

stale bot commented Apr 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label Apr 12, 2022
@BlackHole1 BlackHole1 removed the stale Stale issues or PR label Apr 12, 2022
@crimx
Copy link
Member

crimx commented May 28, 2022

Storybook 6.5 has brought vite builder into the official core.
https://storybook.js.org/blog/storybook-6-5/#vite-builder-for-instant-rebuilds

@Cyberhan123
Copy link
Contributor Author

Storybook 6.5 has brought vite builder into the official core. https://storybook.js.org/blog/storybook-6-5/#vite-builder-for-instant-rebuilds

I'll start investigating this migration

@stale
Copy link

stale bot commented Jul 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label Jul 29, 2022
@stale stale bot closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues or PR
Projects
None yet
Development

No branches or pull requests

4 participants