Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(project): optimize SVGs #1152

Merged
merged 1 commit into from
Nov 29, 2021
Merged

perf(project): optimize SVGs #1152

merged 1 commit into from
Nov 29, 2021

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Nov 27, 2021 •
edited
Loading

Resolve #1149

How do I optimize those files?

npm i -g svgo
cd flat			# Enter the project root
svgo --multipass -rf ./

Diffs preivew

Click here to expand
Before After

hyrious
hyrious previously approved these changes Nov 27, 2021
View reviewed changes
@BlackHole1
Copy link
Collaborator

this is GREAT!!

It might be better if we could use it as an automation. (see: https://github.com/netless-io/flat/blob/main/.husky/pre-commit)

@LitoMore
Copy link
Member Author

LitoMore commented Nov 28, 2021 •
edited
Loading

It might be better if we could use it as automation.

We can lint SVGs with https://github.com/birjolaxew/svglint in another PR.

@BlackHole1 BlackHole1 merged commit 0145f9f into netless-io:main Nov 29, 2021
@LitoMore LitoMore deleted the optimize-svgs branch November 29, 2021 02:03
@BlackHole1 BlackHole1 mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyrious hyrious hyrious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pref]: SVGs need to be optimized.
3 participants
@LitoMore @BlackHole1 @hyrious