Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(renderer-app): change render app bundler to vite #1265

Merged
merged 27 commits into from
Jan 14, 2022
Merged

feat(renderer-app): change render app bundler to vite #1265

merged 27 commits into from
Jan 14, 2022

Conversation

Cyberhan123
Copy link
Contributor

No description provided.

@Cyberhan123 Cyberhan123 mentioned this pull request Jan 4, 2022
Closed
6 tasks
hyrious
hyrious previously approved these changes Jan 5, 2022
View reviewed changes
BlackHole1
BlackHole1 requested changes Jan 5, 2022
View reviewed changes
desktop/renderer-app/index.html Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
LitoMore
LitoMore reviewed Jan 5, 2022
View reviewed changes
desktop/renderer-app/index.html Outdated Show resolved Hide resolved
desktop/renderer-app/index.html Outdated Show resolved Hide resolved
desktop/renderer-app/index.html Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron.ts Outdated Show resolved Hide resolved
desktop/renderer-app/typings/global.d.ts Outdated Show resolved Hide resolved
@Cyberhan123
Copy link
Contributor Author

Cyberhan123 commented Jan 5, 2022 •
edited

I will replace hardcode to template

@netless-io netless-io deleted a comment from BlackHole1 Jan 5, 2022
BlackHole1
BlackHole1 requested changes Jan 6, 2022
View reviewed changes
desktop/renderer-app/scripts/vite-plugin-electron/lib.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/lib.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/options.ts Outdated Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Show resolved Hide resolved
BlackHole1
BlackHole1 requested changes Jan 11, 2022
View reviewed changes
desktop/renderer-app/scripts/vite-plugin-electron/index.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/utils.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/utils.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/utils.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/utils.ts Outdated Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Outdated Show resolved Hide resolved
desktop/renderer-app/tsconfig.json Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/index.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/index.ts Outdated Show resolved Hide resolved
desktop/renderer-app/scripts/vite-plugin-electron/index.ts Outdated Show resolved Hide resolved
BlackHole1
BlackHole1 requested changes Jan 11, 2022
View reviewed changes
.idea/codeStyles/Project.xml Outdated Show resolved Hide resolved
BlackHole1
BlackHole1 requested changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing an issue that prevents you from starting after packing

desktop/renderer-app/vite.config.ts Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Show resolved Hide resolved
@BlackHole1 BlackHole1 merged commit ad71ae8 into netless-io:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@crimx crimx Awaiting requested review from crimx

@Cheerego7 Cheerego7 Awaiting requested review from Cheerego7

@Matrixbirds Matrixbirds Awaiting requested review from Matrixbirds

@syt-honey syt-honey Awaiting requested review from syt-honey

@LitoMore LitoMore Awaiting requested review from LitoMore

@hyrious hyrious Awaiting requested review from hyrious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cyberhan123 @hyrious @LitoMore @BlackHole1