Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flat-server-api): fix email language error #1986

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

syt-honey
Copy link
Member

I wonder if phone numbers also need to be differentiated by language? @Leooeloel

@hyrious
Copy link
Member

hyrious commented Aug 7, 2023

I wonder if phone numbers also need to be differentiated by language?

I guess no. The server has set different template for different country codes https://github.com/netless-io/flat-server/blob/main/config/test.yaml#L113 (although it can only tell the prefix).

@syt-honey
Copy link
Member Author

I wonder if phone numbers also need to be differentiated by language?

I guess no. The server has set different template for different country codes https://github.com/netless-io/flat-server/blob/main/config/test.yaml#L113 (although it can only tell the prefix).

OK, you are right

@syt-honey syt-honey requested a review from hyrious August 7, 2023 09:01
@syt-honey syt-honey merged commit 0a258ae into netless-io:main Aug 7, 2023
2 checks passed
@syt-honey syt-honey deleted the email-language branch August 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants