Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates heading levels for blog index #22

Merged
merged 1 commit into from Feb 18, 2022
Merged

Conversation

maxcell
Copy link
Contributor

@maxcell maxcell commented Feb 18, 2022

Summary

To make sure that our experience can have the correct announcements and expectations for users, we updated the heading order to move from h1 -> h3 to h1 -> h2.

Using Tailwind's CSS classnames, nothing will be changed as far as the visually rendered output but the semantics are more precise.

Fixes #21

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for bejamas-nextjs-blog ready!

🔨 Explore the source changes: b45dfa4

🔍 Inspect the deploy log: https://app.netlify.com/sites/bejamas-nextjs-blog/deploys/620ff0b0f499700008618f95

😎 Browse the preview: https://deploy-preview-22--bejamas-nextjs-blog.netlify.app

Copy link

@JonathanSpeek JonathanSpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kylo approves

Thanks!!

@maxcell maxcell merged commit e24bf54 into main Feb 18, 2022
@maxcell maxcell deleted the pw/21/update-headings branch February 18, 2022 20:23
Lysak pushed a commit to Lysak/blog-web that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog feed skips heading order
2 participants