fix: handle missing angular dependencis error #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ascorbic
reviewed
Nov 27, 2023
|
it looks like the test runs are installing the plugin from NPM, as opposed to using the local one 🤔 https://github.com/netlify/angular-runtime/actions/runs/7004802463/job/19053297061?pr=91#step:6:285 |
JGAntunes
commented
Nov 27, 2023
| @@ -12,12 +12,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macOS-latest, windows-latest] | |||
| node-version: [18.13.0, '*'] | |||
There was a problem hiding this comment.
Bumped the CI execution to latest 18 as we were hitting some limitations with the node test runner:
- https://github.com/search?q=repo%3Anodejs%2Fnode+ERR_TAP_LEXER_ERROR&type=issues
- https://github.com/netlify/angular-runtime/actions/runs/7008488677/job/19064901851
Which have been fixed since then.
Skn0tt
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #87, our observability picked up on another unhandled internal error:
This time is the unhandled
resolveexception. This should take care of that hopefully 👍