Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add better PHP support #135

Merged
merged 2 commits into from Feb 6, 2018
Merged

Add better PHP support #135

merged 2 commits into from Feb 6, 2018

Conversation

brycekahle
Copy link
Contributor

Remove php 5.5, add 7.2.2
Automatically install composer dependencies and cache them.

Fixes #124
Fixes #102

Co-Authored-By: Arnaud Ligny github@narno.org

Remove php 5.5, add 7.2.2
Automatically install composer dependencies and cache them.

Fixes #124
Fixes #102

Co-Authored-By: Arnaud Ligny <github@narno.org>
@brycekahle brycekahle changed the title Add better PHP support [WIP] Add better PHP support Feb 6, 2018
Copy link
Member

@rybit rybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to start passing the php version through to these commands.

@brycekahle
Copy link
Contributor Author

It is just another env var that can be set for a site and passed. No special support needed.

@brycekahle brycekahle changed the title [WIP] Add better PHP support Add better PHP support Feb 6, 2018
@brycekahle brycekahle merged commit 4612514 into master Feb 6, 2018
@brycekahle brycekahle deleted the better-php-support branch February 6, 2018 22:11
@ArnaudLigny
Copy link

ArnaudLigny commented Feb 7, 2018

Thanks for your great job @brycekahle! 👍

There is a way to contribute to the official documentation? https://www.netlify.com/docs/build-settings/#build-environment-variables

@brycekahle
Copy link
Contributor Author

@Narno not at the moment. Once this is live, I'll make sure our docs team makes the necessary changes.

@minthemiddle
Copy link

@brycekahle How can I find out when it is live? Would be willing to write a tutorial on how to use it.

@brycekahle
Copy link
Contributor Author

@minthemiddle This is live now.

@minthemiddle
Copy link

minthemiddle commented Feb 22, 2018

I just published

“Just commit to git: Build static pages continuously using PHP generators like Jigsaw on Netlify”

https://medium.com/@martin_betz/just-commit-to-git-build-static-pages-continuously-using-php-generators-like-jigsaw-on-netlify-4a3a18327ffa

where I use all the latest improvements on PHP in the build image.

@brycekahle
Copy link
Contributor Author

Awesome. Thanks for the shout out!

@nelson6e65
Copy link

There is a way to set environment variables to customize composer install args? For example, I need to use --ignore-platform-req=php in a specific site

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants