This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 197
Add Clojure CLI tools #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ok, this didn't work unfortunately, and I don't have time to look into clojure specifically so closing. Hopefully we can land #187 or homebrew-linux and people can just self serve these tools. |
kyptin
added a commit
to kyptin/build-image
that referenced
this pull request
Mar 21, 2019
Many people using Clojure are migrating away from Leiningen and Boot and using the newer Clojure CLI [1] to specify dependencies and build scripts. This commit adds support for the Clojure CLI tools to the Netlify build image, approximately following the Linux installation instructions [2]. I also added the apt `rlwrap` package because the `clj` program requires it. The `clojure` program does not, but I think many people are calling `clj` instead of `clojure` out of habit. There have been two prior pull requests attempting to add these tools [3] [4]. I think both failed to successfully build the docker image. I have verified that the Dockerfile in this commit does successfully build an image, and I have used that image to successfully build a project of mine [5] that uses the Clojure CLI tools, so I'm reasonably confident that this works. [1] https://clojure.org/guides/deps_and_cli [2] https://clojure.org/guides/getting_started#_installation_on_linux [3] netlify#247 [4] netlify#279 [5] https://gitlab.com/unc-app-lab/website
Merged
kyptin
added a commit
to kyptin/build-image
that referenced
this pull request
Jun 26, 2019
Many people using Clojure are migrating away from Leiningen and Boot and using the newer Clojure CLI [1] to specify dependencies and build scripts. This commit adds support for the Clojure CLI tools to the Netlify build image, approximately following the Linux installation instructions [2]. I also added the apt `rlwrap` package because the `clj` program requires it. The `clojure` program does not, but I think many people are calling `clj` instead of `clojure` out of habit. There have been two prior pull requests attempting to add these tools [3] [4]. I think both failed to successfully build the docker image. I have verified that the Dockerfile in this commit does successfully build an image, and I have used that image to successfully build a project of mine [5] that uses the Clojure CLI tools, so I'm reasonably confident that this works. [1] https://clojure.org/guides/deps_and_cli [2] https://clojure.org/guides/getting_started#_installation_on_linux [3] netlify#247 [4] netlify#279 [5] https://gitlab.com/unc-app-lab/website
kyptin
added a commit
to kyptin/build-image
that referenced
this pull request
Jan 16, 2020
Many people using Clojure are migrating away from Leiningen and Boot and using the newer Clojure CLI [1] to specify dependencies and build scripts. This commit adds support for the Clojure CLI tools to the Netlify build image, approximately following the Linux installation instructions [2]. I also added the apt `rlwrap` package because the `clj` program requires it. The `clojure` program does not, but I think many people are calling `clj` instead of `clojure` out of habit. There have been two prior pull requests attempting to add these tools [3] [4]. I think both failed to successfully build the docker image. I have verified that the Dockerfile in this commit does successfully build an image, and I have used that image to successfully build a project of mine [5] that uses the Clojure CLI tools, so I'm reasonably confident that this works. [1] https://clojure.org/guides/deps_and_cli [2] https://clojure.org/guides/getting_started#_installation_on_linux [3] netlify#247 [4] netlify#279 [5] https://gitlab.com/unc-app-lab/website
kyptin
added a commit
to kyptin/build-image
that referenced
this pull request
Feb 29, 2020
Many people using Clojure are migrating away from Leiningen and Boot and using the newer Clojure CLI [1] to specify dependencies and build scripts. This commit adds support for the Clojure CLI tools to the Netlify build image, approximately following the Linux installation instructions [2]. I also added the apt `rlwrap` package because the `clj` program requires it. The `clojure` program does not, but I think many people are calling `clj` instead of `clojure` out of habit. There have been two prior pull requests attempting to add these tools [3] [4]. I think both failed to successfully build the docker image. I have verified that the Dockerfile in this commit does successfully build an image, and I have used that image to successfully build a project of mine [5] that uses the Clojure CLI tools, so I'm reasonably confident that this works. [1] https://clojure.org/guides/deps_and_cli [2] https://clojure.org/guides/getting_started#_installation_on_linux [3] netlify#247 [4] netlify#279 [5] https://gitlab.com/unc-app-lab/website
Benaiah
pushed a commit
that referenced
this pull request
Mar 2, 2020
Many people using Clojure are migrating away from Leiningen and Boot and using the newer Clojure CLI [1] to specify dependencies and build scripts. This commit adds support for the Clojure CLI tools to the Netlify build image, approximately following the Linux installation instructions [2]. I also added the apt `rlwrap` package because the `clj` program requires it. The `clojure` program does not, but I think many people are calling `clj` instead of `clojure` out of habit. There have been two prior pull requests attempting to add these tools [3] [4]. I think both failed to successfully build the docker image. I have verified that the Dockerfile in this commit does successfully build an image, and I have used that image to successfully build a project of mine [5] that uses the Clojure CLI tools, so I'm reasonably confident that this works. [1] https://clojure.org/guides/deps_and_cli [2] https://clojure.org/guides/getting_started#_installation_on_linux [3] #247 [4] #279 [5] https://gitlab.com/unc-app-lab/website
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #247