Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd linting errors #104

Closed
DavidWells opened this issue Sep 30, 2019 · 2 comments
Closed

Odd linting errors #104

DavidWells opened this issue Sep 30, 2019 · 2 comments
Assignees

Comments

@DavidWells
Copy link
Contributor

Maybe just my IDE but I'm seeing this in build/bin.js

image

Temporarily disabled this via /* eslint-disable node/no-unpublished-bin,node/no-unsupported-features */

Is node 4 set as a version somewhere in dev tooling?

@ehmicky
Copy link
Contributor

ehmicky commented Sep 30, 2019

Is ESLint in the CLI (npm run test:lint) showing the error as well?

I don't think my IDE (VSCode) is showing this, I think you're using Atom, is that correct?

The only Node.js version that is set at the moment is 8.12.0 inside the top-level package.json engines.node property. It's temporary and based on current actual support (e.g. execa crashes on Node.js <8.12.0) but I have opened an issue #81 about this question.

I think eslint-plugin-node should pick that up but maybe it does not work because of the nested package.json inside @netlify/build? That one does not specify any Node.js version at the moment.

@DavidWells
Copy link
Contributor Author

yeah its just my editor 🙄

(╯°□°)╯︵ ┻━┻

Will figure it out later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants