chore: fix Node 8 in CI #2364
Merged
chore: fix Node 8 in CI #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This monorepo uses workspaces which are only available in npm@7.
Our CI runs tests on Node 8 and 15. However, Node 8 does not come with npm@7. This means that packages are not linked between each other. This results in
@netlify/buildusing old version of them, when the PR adds changes to one of them.The current solution runs
npm installin each monorepo package when in Node 8. However, this does not link packages. This PR useslernainstead, on Node 8 only.Note: this PR is the reason why Node 8 tests were failing on #2288