fix: use pure ES modules at the monorepo top level #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 20, 2021
| const { overrides } = require('@netlify/eslint-config-node') | ||
|
|
||
| module.exports = { | ||
| extends: ['plugin:fp/recommended', '@netlify/eslint-config-node'], | ||
| parserOptions: { | ||
| sourceType: 'module', |
There was a problem hiding this comment.
The ESLint configuration can be simplified in several ways, now that every package is using pure ES modules.
ehmicky
force-pushed
the
fix/monorepo-pure-esm
branch
from
d654f03
to
728a18e
Compare
ehmicky
commented
Dec 20, 2021
| { | ||
| files: ['packages/*/tests/**/*.{cjs,mjs,js}'], | ||
| rules: { | ||
| 'no-magic-numbers': 'off', |
There was a problem hiding this comment.
Re-enable this rule since only a few statements were offending.
ehmicky
commented
Dec 20, 2021
| @@ -1,2 +1,2 @@ | |||
| [[plugins]] | |||
| package = "./plugin" | |||
| package = "./plugin.cjs" | |||
There was a problem hiding this comment.
Some test files must be renamed to .cjs to get the right linting.
ehmicky
commented
Dec 20, 2021
| @@ -3,7 +3,7 @@ | |||
| "private": true, | |||
| "version": "0.0.0", | |||
| "description": "Netlify build module", | |||
| "main": "index.js", | |||
| "type": "module", | |||
There was a problem hiding this comment.
That's the main change.
ehmicky
commented
Dec 20, 2021
| @@ -3,7 +3,7 @@ | |||
| "private": true, | |||
| "version": "0.0.0", | |||
| "description": "Netlify build module", | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
The top-level package.json is not published to npm and does not have any main/exports file.
erezrokah
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3742
Every package of this monorepo is now using pure ES modules, including
@netlify/buildand@netlify/config.There is a top-level package which is not published and is not needed in development as part of the monorepo structure. This PR makes that top-level and related top-level files use pure ES modules as well.
This has no impact on published code, only on development code.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.