Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detected frameworks cannot use the static server #3655

Closed
ascorbic opened this issue Nov 18, 2021 · 2 comments · Fixed by #4020
Closed

Auto-detected frameworks cannot use the static server #3655

ascorbic opened this issue Nov 18, 2021 · 2 comments · Fixed by #4020
Assignees
Labels
status: blocked type: bug code to address defects in shipped code

Comments

@ascorbic
Copy link
Contributor

Describe the bug

If a framework has an entry in framework-info it disables the static server, meaning that any framework that needs this cannot use auto-detection, so misses out on the other benefits of auto-detection, such as build command.

To Reproduce
Cannot be reproduced because it would require adding a framework to framework-info, but the code is here:
https://github.com/netlify/cli/blob/main/src/utils/detect-server-settings.js#L260

This is related to #3654, and could be fixed with a similar solution to that, or more simply by starting the static server if the framework specifies no dev command and/or target port.

@ascorbic ascorbic added the type: bug code to address defects in shipped code label Nov 18, 2021
@erezrokah
Copy link
Contributor

erezrokah commented Nov 18, 2021

My comment here is relevant for this issue too

@erezrokah
Copy link
Contributor

@ascorbic I opened netlify/framework-info#657.

Once we have that I think this issue will be about adding useStaticServer: true here

pollingStrategies,
when a command/port is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants