Fix identical operands and always true condition #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Jan 3, 2022
| @@ -17,7 +17,7 @@ const parseRawFlags = function (raw) { | |||
| const next = array[index + 1] | |||
| if (!next) { | |||
| acc[key] = true | |||
| } else if (next && next && /^-{1,2}/.test(next)) { | |||
| } else if (/^-{1,2}/.test(next)) { | |||
There was a problem hiding this comment.
This could probably be refactored to next.startsWith('--') || next.startsWith('-'), not sure it's better though.
|
@erezrokah there's only one similar warning left: https://lgtm.com/projects/g/netlify/cli/snapshot/5b5a2104db065d78dc216937317a0b77923105d9/files/src/utils/telemetry/validation.js?sort=name&dir=ASC&mode=heatmap I'm not super familiar with the codebase, so it'd be nice if you or someone else could take care of it. |
gavinhenderson
pushed a commit
to gavinhenderson/cli
that referenced
this pull request
Jan 5, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixing more LGTM issues
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)