New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont show warning message for toml-defined scheduled functions #4162
Merged
netlify-team-account-1
merged 4 commits into
main
from
scheduled-functions-invoke-toml-bug
Jan 31, 2022
Merged
fix: dont show warning message for toml-defined scheduled functions #4162
netlify-team-account-1
merged 4 commits into
main
from
scheduled-functions-invoke-toml-bug
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: Alexander Karagulamos <alex-contractor@netlify.com>
co-authored-by: Alexander Karagulamos <alex-contractor@netlify.com>
📊 Benchmark resultsComparing with 0550e60 Package size: 360 MB(no change)
Legend
|
erezrokah
previously approved these changes
Jan 31, 2022
eduardoboucas
previously approved these changes
Jan 31, 2022
eduardoboucas
approved these changes
Jan 31, 2022
netlify-team-account-1
deleted the
scheduled-functions-invoke-toml-bug
branch
January 31, 2022 21:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This PR fixes a bug discovered by @minivan, where our warning message was off when a toml-defined scheduled function was invoked with
functions:invoke
.For us to review and ship your PR efficiently, please perform the following steps:
A picture of a cute animal (not mandatory, but encouraged)