feat(graph): allow sharing VCS branches through a lockfile #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
📊 Benchmark resultsComparing with b3dc897 Package size: 230 MB⬆️ 0.04% increase vs. b3dc897 Legend
|
sgrove
previously approved these changes
Aug 4, 2022
| * @param {NetlifyGraphLockfile.V0_format} input.lockfile | ||
| */ | ||
| const writeLockfile = ({ lockfile, siteRoot }) => { | ||
| writeFileSync(path.join(siteRoot, NetlifyGraphLockfile.defaultLockFileName), JSON.stringify(lockfile, null, 2)) |
There was a problem hiding this comment.
I suspect in the near future we may want a normalizeLockfile function that inserts all the known keys in a deterministic order so that the JSON file is always written out in the same order as well, to prevent spurious changes in git
There was a problem hiding this comment.
I like that we enforce that invariant in the future. It should hopefully be the case right now if the entrypoint is always NetlifyGraphLockfile.createLockfile
src/lib/one-graph/cli-client.js
Outdated
| */ | ||
| const handleOperationsLibraryPersistedEvent = async (input) => { | ||
| const { schemaId, siteRoot } = input | ||
| // await updateGraphQLOperationsFileFromPersistedDoc() |
|
|
||
| const relevantHasLength = 10 | ||
| writeGraphQLOperationsSourceFile({ logger, netlifyGraphConfig, operationsDocString }) | ||
| regenerateFunctionsFileFromOperationsFile({ netlifyGraphConfig, schema }) |
There was a problem hiding this comment.
I think we'll need schemaId here
| */ | ||
| const maybeUpdateSessionFromLockfile = async (input) => { | ||
| const { lockfile, netlifyToken, session } = input | ||
| const sessionSchemaId = session.metadata && session.metadata.schemaId |
There was a problem hiding this comment.
We should update the underlying query to get session.graphQLSchema.id when it's less painful to do so.
| @@ -718,29 +820,80 @@ const generateSessionName = () => { | |||
| return sessionName | |||
| } | |||
|
|
|||
| /** | |||
| * Mark a session as inactive so it doesn't show up in any UI lists, and potentially becomes available to GC later | |||
There was a problem hiding this comment.
Is this doctoring correct? And the name would probably be better as idempotentlyUpdateSessionSchemaIdFromLockfile
anmonteiro
added
type: feature
sgrove
previously approved these changes
Aug 4, 2022
sgrove
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #<replace_with_issue_number>
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)