New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow for in-source-config internal edge functions in proxy #5311
fix: allow for in-source-config internal edge functions in proxy #5311
Conversation
π Benchmark resultsComparing with 6214768 Package size: 242 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β¨
} catch { | ||
return { | ||
functions: [], | ||
path: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to be a bit more consistent, we could make path: undefined
here and then in src/lib/edge-functions/proxy.mjs
make the check:
const hasEdgeFunctions = userFunctionsPath !== undefined || internalFunctionsPath !== undefined
Not a huge deal, though.
π Thanks for submitting a pull request! π
Summary
Should fix an issue where having any internal functions with in-source-config, but no other edge functions, would prevent the proxy from running the internal EF.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)