fix: support Blobs in unlinked sites #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Jan 2, 2024
| @@ -157,7 +157,7 @@ export const createHandler = function (options) { | |||
| 'client-ip': [remoteAddress], | |||
| 'x-nf-client-connection-ip': [remoteAddress], | |||
| 'x-nf-account-id': [options.accountId], | |||
| 'x-nf-site-id': [options?.siteInfo?.id] ?? 'unlinked', | |||
There was a problem hiding this comment.
This was the problem. [options?.siteInfo?.id] is never falsy, even when options?.siteInfo?.id is undefined, so the fallback string never kicked in.
eduardoboucas
commented
Jan 2, 2024
| @@ -28,7 +28,7 @@ const printLocalBlobsNotice = () => { | |||
| } | |||
|
|
|||
| const startBlobsServer = async (debug: boolean, projectRoot: string, token: string) => { | |||
| const directory = path.resolve(projectRoot, getPathInProject(['blobs-serves'])) | |||
| const directory = path.resolve(projectRoot, getPathInProject(['blobs-serve'])) | |||
There was a problem hiding this comment.
Unrelated to the fix, but blobs-serves was a typo. It should be blobs-serve, in line with functions-serve and edge-functions-serve.
There was a problem hiding this comment.
I forgot to mention this! I saw the directory and guessed it was a typo.
Skn0tt
approved these changes
Jan 2, 2024
ascorbic
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to support Blobs in Netlify Dev even if the site is not linked — this was supposed to be addressed by #6176, but it didn't work properly (I've added more context in a comment). This PR fixes that.
Closes https://linear.app/netlify/issue/COM-211/blobs-possibly-not-working-in-framework-generated-functions.