Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow proxy rules logs to be hidden when inserted by plugin #6453

Merged
merged 6 commits into from Mar 20, 2024

Conversation

mraerino
Copy link
Member

@mraerino mraerino commented Mar 19, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

ref CRE-1135

We have a need to be able to hide the "proxying to ..." logs for the internal dev server handler.

This is a pretty scrappy solution but the only one i could find without a lot of refactoring.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@mraerino mraerino self-assigned this Mar 19, 2024
Copy link

github-actions bot commented Mar 19, 2024

πŸ“Š Benchmark results

  • Dependency count: 1,326
  • Package size: 298 MB
  • Number of ts-expect-error directives: 1,029

@mraerino mraerino marked this pull request as ready for review March 20, 2024 11:08
@mraerino mraerino requested a review from a team as a code owner March 20, 2024 11:08
lemusthelroy
lemusthelroy previously approved these changes Mar 20, 2024
@mraerino mraerino changed the title feat: allow proxy rules logs to be hidden when inserted feat: allow proxy rules logs to be hidden when inserted by plugin Mar 20, 2024
@mraerino mraerino enabled auto-merge (squash) March 20, 2024 11:47
@mraerino mraerino merged commit c2e94bc into main Mar 20, 2024
40 checks passed
@mraerino mraerino deleted the feat/hidden-proxies branch March 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants