Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow skipping the target port wait #6472

Merged
merged 2 commits into from Mar 26, 2024
Merged

feat: allow skipping the target port wait #6472

merged 2 commits into from Mar 26, 2024

Conversation

davbree
Copy link
Contributor

@davbree davbree commented Mar 26, 2024

Summary

Allow skipping the target port wait. This allows us to manage the dev server status externally.

ref CRE-1150


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@davbree davbree requested a review from a team as a code owner March 26, 2024 10:06
Copy link

github-actions bot commented Mar 26, 2024

πŸ“Š Benchmark results

Comparing with cd19d2b

  • Dependency count: 1,328 (no change)
  • Package size: 298 MB (no change)
  • Number of ts-expect-error directives: 1,029 (no change)

@davbree davbree requested a review from a team as a code owner March 26, 2024 10:31
@davbree davbree merged commit cfa8e2b into main Mar 26, 2024
40 checks passed
@davbree davbree deleted the devserver-skip-wait branch March 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants