Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't prompt for input when running in CI #6541

Merged
merged 10 commits into from May 7, 2024
Merged

fix: don't prompt for input when running in CI #6541

merged 10 commits into from May 7, 2024

Conversation

davbree
Copy link
Contributor

@davbree davbree commented May 1, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Fix cases where netlify dev prompts for input while running in dev server

ref CRE-1211


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@davbree davbree requested a review from a team as a code owner May 1, 2024 08:04
Copy link

github-actions bot commented May 1, 2024

πŸ“Š Benchmark results

Comparing with fdc34d4

  • Dependency count: 1,329 (no change)
  • Package size: 310 MB ⬆️ 0.00% increase vs. fdc34d4
  • Number of ts-expect-error directives: 997 (no change)

eduardoboucas
eduardoboucas previously approved these changes May 2, 2024
src/commands/base-command.ts Outdated Show resolved Hide resolved
src/utils/build-info.ts Outdated Show resolved Hide resolved
@davbree davbree requested a review from eduardoboucas May 5, 2024 08:52
src/commands/base-command.ts Outdated Show resolved Hide resolved
src/utils/build-info.ts Outdated Show resolved Hide resolved
davbree and others added 3 commits May 6, 2024 18:56
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
@davbree davbree requested a review from eduardoboucas May 6, 2024 15:59
eduardoboucas
eduardoboucas previously approved these changes May 6, 2024
exports[`frameworks/framework-detection > should fail in CI when multiple frameworks are detected 1`] = `
"β—ˆ Netlify Dev β—ˆ
Multiple possible dev commands found
β—ˆ Detected commands for: Gatsby, Create React App. Update your settings to specify which to use. See docs at: https://docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

eduardoboucas
eduardoboucas previously approved these changes May 6, 2024
@davbree davbree merged commit a3c496b into main May 7, 2024
47 checks passed
@davbree davbree deleted the dev-no-prompt branch May 7, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants