Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: always compress folders before deploy #19

Closed
vvo opened this issue Jan 19, 2017 · 3 comments
Closed

Proposal: always compress folders before deploy #19

vvo opened this issue Jan 19, 2017 · 3 comments

Comments

@vvo
Copy link

vvo commented Jan 19, 2017

Hi, I noticed that when you use netlify deploy on a folder, it will be a lot slower than deploying that same folder as a zip file (expected).

What if the netlify-cli automatically compressed folders before sending them to netlify servers? We could use https://github.com/archiverjs/node-archiver for that.

I would like to hear your feedback on this as there may be a good reason for not compressing folders before sending over the wire.

As a first step, maybe the documentation could be explicit about the fact that folders are sent uncompressed and if you do not have an optic fiber setup then compressing to a zip before sending can be a good idea.

Thanks!

@fool
Copy link
Contributor

fool commented Aug 10, 2017

Hi there and sorry to be so slow to respond. We have basically stopped development on netlify-cli and are focusing on netlifyctl . So I doubt we'll add this feature, but PR's are accepted if you want to take a shot at it.

@biilmann
Copy link
Member

In general, not compressing the folders will be faster since with this method we do incremental deploys (ie, we only ship the files that changed) whereas zip based deploys needs to send all files on each deploy.

@vvo
Copy link
Author

vvo commented Aug 28, 2017

I am fine with your answer, thanks

@vvo vvo closed this as completed Aug 28, 2017
bcomnes added a commit that referenced this issue Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants