Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect pull-requests correctly #302

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

danez
Copy link
Contributor

@danez danez commented Jul 7, 2022

Summary

The previous logic for some reason got confused in netlify/cli, and assigned the run to a PR even though it was a commit on the default branch. Not sure why github added PR 136 to the API response.

https://github.com/netlify/cli/runs/7230475784?check_suite_focus=true

##[debug]This run is related to PR #136

@danez danez added the type: bug code to address defects in shipped code label Jul 7, 2022
@danez danez requested a review from Skn0tt July 7, 2022 09:58
@danez danez merged commit 7edd063 into main Jul 7, 2022
@danez danez deleted the fix/danez/detect-pr-better branch July 7, 2022 12:33
@danez danez restored the fix/danez/detect-pr-better branch July 8, 2022 08:22
@danez danez deleted the fix/danez/detect-pr-better branch July 8, 2022 08:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants