fix: tag edge function signature errors as user errors (#209)

* fix: tag edge function signature errors as user errors
netlify · Nov 18, 2022 · 5d5a50f · 5d5a50f
1 parent 887afbc
commit 5d5a50f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/node/bundle_error.ts b/node/bundle_error.ts
@@ -2,9 +2,9 @@ interface BundleErrorOptions {
   format: string
 }
 
-const getCustomErrorInfo = (options: BundleErrorOptions) => ({
+const getCustomErrorInfo = (options?: BundleErrorOptions) => ({
   location: {
-    format: options.format,
+    format: options?.format,
     runtime: 'deno',
   },
   type: 'functionsBundling',
@@ -13,7 +13,7 @@ const getCustomErrorInfo = (options: BundleErrorOptions) => ({
 class BundleError extends Error {
   customErrorInfo: ReturnType<typeof getCustomErrorInfo>
 
-  constructor(originalError: Error, options: BundleErrorOptions) {
+  constructor(originalError: Error, options?: BundleErrorOptions) {
     super(originalError.message)
 
     this.customErrorInfo = getCustomErrorInfo(options)
@@ -28,7 +28,7 @@ class BundleError extends Error {
 /**
  * BundleErrors are treated as user-error, so Netlify Team is not alerted about them.
  */
-const wrapBundleError = (input: unknown, options: BundleErrorOptions) => {
+const wrapBundleError = (input: unknown, options?: BundleErrorOptions) => {
   if (input instanceof Error) {
     return new BundleError(input, options)
   }

diff --git a/node/config.ts b/node/config.ts
@@ -5,6 +5,7 @@ import { pathToFileURL } from 'url'
 import tmp from 'tmp-promise'
 
 import { DenoBridge } from './bridge.js'
+import { BundleError } from './bundle_error.js'
 import { EdgeFunction } from './edge_function.js'
 import { ImportMap } from './import_map.js'
 import { Logger } from './logger.js'
@@ -123,8 +124,10 @@ const logConfigError = (func: EdgeFunction, exitCode: number, stderr: string, lo
       break
 
     case ConfigExitCode.InvalidDefaultExport:
-      throw new Error(
-        `Default export in '${func.path}' must be a function. More on the Edge Functions API at https://ntl.fyi/edge-api.`,
+      throw new BundleError(
+        new Error(
+          `Default export in '${func.path}' must be a function. More on the Edge Functions API at https://ntl.fyi/edge-api.`,
+        ),
       )
 
     default: