feat: add support for import maps with ESZIP #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `importMaps` now expects a `baseURL` containing the URL of the import map file
eduardoboucas
added
the
type: feature
khendrikse
approved these changes
Sep 9, 2022
This was referenced Sep 13, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* feat: add support for import maps with ESZIP BREAKING CHANGE: `importMaps` now expects a `baseURL` containing the URL of the import map file * refactor: simplify import map parsing * refactor: use `URL` objects internally Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for import maps was limited when producing ESZIP bundles, because thee loader function wasn't being called for specifiers that looked like relative file paths, and therefore those were not respecting the import map.
With this PR, we're using native support for import maps in https://deno.land/x/eszip@v0.28.0 rather than resolving them ourselves in the loader function.
NOTE: Netlify Build will need to start sending a
baseURLproperty with the path of the import map file itself (here), so that we know how to resolve any relative paths in the import map.Closes #108.