feat!: move internal config file to Edge Bundler #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
jackiewmacharia
approved these changes
Nov 23, 2022
1 task
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…r#219) * feat!: move internal config file to Edge Bundler * refactor: remove `importMaps` parameter from `bundle` * refactor: add early return * chore: fix test * fix: add fallback value to import map * refactor: change `ImportMap` interface * chore: update test Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Framework-generated functions are currently configured using a
manifest.jsonfile placed in the.netlify/edge-functionsinternal directory (documented here). This file is currently loaded and parsed in Netlify Build and then its contents are supplied to Edge Bundler via thedeclarations,layersandimportMapsproperties.This PR moves that logic to Edge Bundler, such that the
bundleentry point receives an optionalconfigPathproperty which indicates the path to this internal configuration file. I've called thisconfigPathand used the namedeployConfiginternally to allude to the deploy configuration API initiative, which is basically a part of.By moving this from Netlify Build to Edge Bundler we'll be consolidating the bundling logic into one place. This will make it easier, for example, to take the
layersobject into account when extracting the function configuration in the ISC process.