Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests #23

Closed
eduardoboucas opened this issue May 4, 2022 · 3 comments · Fixed by #25
Closed

Fix flaky tests #23

eduardoboucas opened this issue May 4, 2022 · 3 comments · Fixed by #25
Assignees
@jackiewmacharia
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@eduardoboucas
Copy link
Member

eduardoboucas commented May 4, 2022 •
edited

Currently, our test suite actually downloads the Deno CLI binaries as part of each run. This makes the tests flaky and they frequently fail due to network/IO errors. We should consider mocking the HTTP call and using a local version of the Deno CLI.

Update: actually this doesn't seem related to downloading the Deno CLI. It's actually failing on a very specific test when trying to create a JavaScript bundle in parallel with an ESZIP bundle (https://github.com/netlify/edge-bundler/runs/6306315074?check_suite_focus=true#step:7:48)
@eduardoboucas eduardoboucas added the type: chore work needed to keep the product and development running smoothly label May 4, 2022
@eduardoboucas eduardoboucas mentioned this issue May 5, 2022
Merged
@eduardoboucas
Copy link
Member Author

Still not fixed, sadly.

@eduardoboucas eduardoboucas reopened this May 5, 2022
@eduardoboucas eduardoboucas mentioned this issue May 5, 2022
Merged
@jackiewmacharia jackiewmacharia linked a pull request May 23, 2022 that will close this issue
fix: flaky tests (WIP) #37
Closed
2 tasks
@jackiewmacharia
Copy link
Contributor

This hasn't happened for a while, moving to backlog for now.

@eduardoboucas
Copy link
Member Author

Hopefully #139 fixes this. Let's reopen if we see failures again.

Skn0tt pushed a commit to netlify/build that referenced this issue Apr 23, 2024
@eduardoboucas
feat: cache download Promise (netlify/edge-bundler#23)
fa2a659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackiewmacharia jackiewmacharia

Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
2 participants
@eduardoboucas @jackiewmacharia