Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update edge-bundler-bootstrap #96

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Updates edge-bundler-bootstrap to 62f5f45fbc76ed0009624267.

@github-actions github-actions bot requested a review from a team August 12, 2022 06:48
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 12, 2022
@Skn0tt
Copy link
Member

Skn0tt commented Aug 12, 2022

oh no, its not running CI because this PR was created by a bot ... that's unfortunate

@eduardoboucas
Copy link
Member

oh no, its not running CI because this PR was created by a bot ... that's unfortunate

That's not great. We have tests in place to ensure that we're loading a valid bootstrap URL. If all updates are going to be made by a bot, we'll never run those tests. Can we find a way around this?

@kodiakhq kodiakhq bot merged commit 5bc3973 into main Aug 15, 2022
@Skn0tt
Copy link
Member

Skn0tt commented Aug 15, 2022

I believe that the github-app-token-generator is a good way of solving this. Anyway, it doesn't look like the bot integration works all that well - I created this PR by manually invoking the workflow to run. looks like https://github.com/netlify/edge-functions-bootstrap/blob/main/netlify/functions/deploy-succeeded.ts doesn't work as intended

Skn0tt added a commit to netlify/build that referenced this pull request Apr 23, 2024
Co-authored-by: Skn0tt <Skn0tt@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants