Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds updated typography (Pacaembu/Mulish pairing) #508

Merged
merged 1 commit into from
May 28, 2021
Merged

Adds updated typography (Pacaembu/Mulish pairing) #508

merged 1 commit into from
May 28, 2021

Conversation

zachleat
Copy link
Contributor

@zachleat zachleat requested a review from a team May 27, 2021 20:40
@zachleat zachleat added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 27, 2021
@zachleat zachleat mentioned this pull request May 27, 2021
Merged
tzmanics
tzmanics reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@tzmanics tzmanics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @zachleat. Did you mean to push the changes to functions/certificate-3-missions.js? Just in case 'no', I'll wait for your reply before approving 👍

@zachleat
Copy link
Contributor Author

zachleat commented May 27, 2021 •
edited

@tzmanics That was not my file or my changes but it yelled at me because the file wasn’t prettier friendly and didn’t let me commit without those changes 😭

@tzmanics
Copy link
Contributor

well, what prettier wants prettier gets so 🚢

tzmanics
tzmanics approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@tzmanics tzmanics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philhawksworth philhawksworth merged commit c4d86cb into main May 28, 2021
@philhawksworth philhawksworth deleted the zl/506/webfonts branch May 28, 2021 10:02
philhawksworth added a commit that referenced this pull request May 28, 2021
@philhawksworth
Merge branch 'main' into zl/shared-nav
2e3acc9 
* main:
  feat: Adds updated typography https://github.com/netlify/netlify-web-fonts (#508)
@zachleat
Copy link
Contributor Author

Thanks for shipping! 🚢🛳⛴🚀📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzmanics tzmanics tzmanics approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typographic updates to Jamstack Explorers
3 participants
@zachleat @tzmanics @philhawksworth