This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix: update the files entry in package.json #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericapisani
requested review from
danez,
nickytonline,
orinokai and
sarahetter
✅ Deploy Preview for framework-info ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -11,7 +11,7 @@ | |||
| "files": [ | |||
| "build/*.js", | |||
| "src/**/*.js", | |||
| "dist/index.cjs" | |||
| "dist/index.umd.cjs" | |||
There was a problem hiding this comment.
any reason we're shipping a umd file?
There was a problem hiding this comment.
It was a UMD file pre-vite.
And we target this is because of the browser usage of this library (where we detect the framework during the 'import project' part of adding/creating a new site in the Netlify UI)
danez
approved these changes
Oct 28, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #827
This was an entry that I forgot to update when migrating from webpack to vite in #819 .