Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

feat: add frameworks titles #134

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat: add frameworks titles #134

merged 1 commit into from
Feb 10, 2021

Conversation

erezrokah
Copy link
Contributor

Fixes #133

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 10, 2021
erezrokah
erezrokah commented Feb 10, 2021
View reviewed changes
src/frameworks/docusaurus-v2.json
@@ -1,5 +1,6 @@
{
"name": "docusaurus-v2",
"title": "Docusaurus 2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly use v2 in the title as referenced in https://docusaurus.io/

erezrokah
erezrokah commented Feb 10, 2021
View reviewed changes
src/frameworks/quasar-v0.17.json
@@ -1,5 +1,6 @@
{
"name": "quasar-v0.17",
"title": "Quasar",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't include the version this time as it can mean any version lower than v1

JGAntunes
JGAntunes approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it we're already too late to change name for id without breaking a whole lot of things and requiring a whole lot of updates correct? 😅

@erezrokah
Copy link
Contributor Author

I take it we're already too late to change name for id without breaking a whole lot of things and requiring a whole lot of updates correct? 😅

I actually think we could do that as a breaking change.

@erezrokah erezrokah merged commit 4aec35e into master Feb 10, 2021
@erezrokah erezrokah deleted the feat/add_frameworks_titles branch February 10, 2021 11:07
@erezrokah erezrokah mentioned this pull request Feb 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JGAntunes JGAntunes JGAntunes approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add frameworks titles
2 participants
@erezrokah @JGAntunes