Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all google cloud related code into implementation folder #6

Merged
merged 6 commits into from
Feb 24, 2020

Conversation

biilmann
Copy link
Member

This sets the scene for better supporting multiple implementations of the runtime layer.

@biilmann
Copy link
Member Author

This PR restructures the code quite a bit to make it a bit more future friendly.

There's now an implementations folder within both the processor-queue dir and the processors dir.

The implementations in processor-queue is meant as the main runtime for handling pubsub messages, deploying cloud functions and setup up topics, subscribers and buckets.

The implementations folder in the processors dir is meant for the actual cloud functions. They should automatically get deployed by the main runtime's deploy functions.

The plugin will now detect any processors in the processors folder and setup event handling for them.

These changes affects how queues and topics are named, so before upgrading it's necesarry to do a fresh deploy of the functions/buckets/topics.

With this PR the WORKER_TOPIC environment variable also becomes optional and there's now a separate topic/bucket for each potential processor.

@biilmann biilmann merged commit bfdf97b into master Feb 24, 2020
@biilmann biilmann deleted the better-structure branch February 24, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant