Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Add per line item discount to cart object #15

Closed
pukhalski opened this issue Sep 11, 2018 · 2 comments · Fixed by #25
Closed

Add per line item discount to cart object #15

pukhalski opened this issue Sep 11, 2018 · 2 comments · Fixed by #25
Assignees
@mraerino
Labels
feature request

Comments

@pukhalski
Copy link
Contributor

Now only the total discount is calculated but sometimes it is handy to show a per item discount, since there could be a fixed amount discount for one item and a percentage for all because of a coupon used.
@pukhalski pukhalski mentioned this issue Sep 11, 2018
Closed
@pukhalski pukhalski changed the title Add per line item discount to cart object Add per line item discount to cart object [CRITICAL] Sep 11, 2018
@pukhalski pukhalski changed the title Add per line item discount to cart object [CRITICAL] Add per line item discount to cart object Sep 11, 2018
@mraerino mraerino mentioned this issue Dec 12, 2018
Merged
@bcomnes
Copy link
Contributor

bcomnes commented Dec 12, 2018

netlify/gocommerce#124 Is closed now, do we need changes on the JS side?

@bcomnes
Copy link
Contributor

bcomnes commented Dec 12, 2018

Yes we do! #25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mraerino mraerino

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show Details about Pricing Calculation of Line Items in the Cart mraerino/gocommerce-js
4 participants
@phae @bcomnes @pukhalski @mraerino