Receipts endpoint #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was considering URL param for better caching, but since this endpoint is mainly for authenticated requsts, HTTP caching will probably never be used much for it and a query parameter is more intuitive
brycekahle
reviewed
Aug 21, 2017
| @@ -150,7 +150,7 @@ func (a *API) orderRoutes(r *router) { | |||
| }) | |||
|
|
|||
| r.Get("/downloads", a.DownloadList) | |||
| r.Post("/receipt", a.ResendOrderReceipt) | |||
There was a problem hiding this comment.
Did you intend to remove the POST endpoint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
/orders/:order_id/receiptendpoint that will return the HTML receipt for the order.By default this uses the same HTML templates as the OrderConfirmation Mailer, but the endpoint takes an optional
templatequery parameter that specifies another template inside the website that can be used to generate different variation of the receipt (one for the client, maybe one for printing on a box, one representing a ticket, etc)....