Multi tenant #79
Merged
Multi tenant #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move config to environment variables only too
rybit
reviewed
Aug 23, 2017
| return internalServerError("Database error deleting instance").WithInternalError(err) | ||
| } | ||
|
|
||
| // TODO do we delete everything associated with an instance too? |
There was a problem hiding this comment.
Let's do hard remove for now. If we want to change it to soft delete later, we can do that all at once.
| if globalConfig.OperatorToken == "" { | ||
| logrus.Fatal("Operator token secret is required") | ||
| } | ||
| if globalConfig.DB.Namespace != "" { |
There was a problem hiding this comment.
that isn't required right? The namespace corresponds to the name of the tables, which can be empty. We can use a single set of tables regardless of tenancy
There was a problem hiding this comment.
Did you misread something? This is the code:
if globalConfig.DB.Namespace != "" {
models.Namespace = globalConfig.DB.Namespace
}
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
- Summary
Add multi-tenant support. Changes config to environment variables only.
- Test plan
Existing tests pass. A few tests/assertions added.
- Description for the changelog
Add multi-tenant support.