Don't check signup hook content-length

[mikeslattery]

- Do you want to request a feature or report a bug? Bug

- What is the current behavior?

The signup hook response is not parsed, if it doesn't consist of a Content-Type header value. In my hook I was trying to set app_metadata.roles but my value is ignored.

Here's the code and the blame.I think this was added to avoid json parse errors, but POST responses can often have no known length. I think there should still be a check, but on the body text itself, not the header value.

- If the current behavior is a bug, please provide the steps to reproduce.

I stripped out error handling and left out some details that any gotrue dev should know, but this code should work. I copy/pasted snippets from my project.

1. Create and launch an empty netlify nuxt project with netlify-identity. You may need to register with netlify.

yarn create nuxt-app gotrue-test
cd gotrue-test
yarn add -g netlify-cli
yarn add netlify-identity-widget
yarn add -D dotenv jest
netlify dev --live

2. Write a functions/identity-signup/identity-signup.js, that doesn't return a content-length:

exports.handler = function (event, context, callback) {
  const bodyJson = JSON.parse(event.body).user
  if (bodyJson.event === 'signup') {
    bodyJson.app_metadata.roles = ['regular']
  }
  const bodyText = JSON.stringify(bodyJson)
  callback(null, {
    statusCode: 200,
    headers: {
      // WORKAROUND: Uncomment next line as a fix
      // 'Content-Length': bodyText.length,
    },
    body: bodyText,
  })
}

3. Write .env for gotrue and jest to auto-confirm, auto-signup

# .env file
GOTRUE_DISABLE_SIGNUP='false'
GOTRUE_MAILER_AUTOCONFIRM='true'
GOTRUE_SITE_URL='http://localhost:8081'
GOTRUE_WEBHOOK_URL='http://localhost:8888/.netlify/functions/identity-signup'

4. Run gotrue

source .env
export GOTRUE_DISABLE_SIGNUP GOTRUE_MAILER_AUTOCONFIRM GOTRUE_WEBHOOK_URL
gotrue

5. Write and run this jest code:

/**
 * @jest-environment jsdom
 */

describe('Tests', () => {
  test('Missing Content Type', () => {
    const env = require('dotenv').config().parsed
    const netlifyIdentity = require('netlify-identity-widget')
    netlifyIdentity.init({
        APIUrl: env.GOTRUE_SITE_URL,
    })
    await netlifyIdentity.store.signup('Netlify Tester', 'tester@netlify.com', 'password')
    await netlifyIdentity.store.login('tester@netlify.com', 'password')
    
    // This FAILS
    expect(netlifyIdentity.store?.user?.app_metadata?.roles).toEqual(['regular'])
  }
}

- What is the expected behavior?

app_metadata should be modified. See test code above. If you uncomment my workaround, it works correctly.

- Please mention your Go version, and operating system version.

1.15 as comes with golang:1.15-alpine docker image. I use this to build gotrue. This is the same as in go.mod.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 7 days if no further activity occurs. Thanks!

[mikeslattery]

This appears to have been fixed by pull #342