Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading webhook response when content length is unknown #342

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

mraerino
Copy link
Member

@mraerino mraerino commented Apr 26, 2023

- Summary

For https://github.com/netlify/pillar-runtime/issues/723

- Test plan

- Description for the changelog

Fix reading webhook response when content length is unknown

- A picture of a cute animal (not mandatory but encouraged)

@mraerino mraerino self-assigned this Apr 26, 2023
@mraerino mraerino force-pushed the fix/webhook-streamed-response branch 4 times, most recently from a161fbc to f583678 Compare April 26, 2023 20:31
@mraerino mraerino force-pushed the fix/webhook-streamed-response branch from f583678 to 48f9efe Compare April 27, 2023 00:09
@mraerino mraerino marked this pull request as ready for review April 27, 2023 00:38
@mraerino mraerino requested a review from a team April 27, 2023 00:43
@cbosss
Copy link

cbosss commented Apr 28, 2023

This does seem to be the fix. I believe it's due to this change in proxy.

https://github.com/netlify/proxy/pull/1115/files#diff-6f6ad6370aff3fa52cebfe006de01092ec24693bb5a5e17de349f3523b54c605R84

This is why we are no longer setting a Content-Length in the webhook response.

@cbosss cbosss merged commit 381cbd3 into master Apr 28, 2023
@cbosss cbosss deleted the fix/webhook-streamed-response branch April 28, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants