Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip email provider flag to a disabled flag. Defaults to false/enabled #150

Merged
merged 2 commits into from Feb 12, 2018

Conversation

brycekahle
Copy link
Contributor

- Summary
Using a default of true is not possible, because we do not know the difference between the instance config being unset false or overridden false.

- Test plan
Tests pass.

- Description for the changelog
Flip email provider flag to a disabled flag.

@brycekahle brycekahle merged commit 529ae13 into master Feb 12, 2018
@brycekahle brycekahle deleted the fix-email-default branch February 12, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants