Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jwt v4, gofrs uuid, and other deps #276

Closed
wants to merge 6 commits into from

Conversation

jrapoport
Copy link

- Summary

Upgrade to jwt v4, gofrs uuid, and other dependencies.

Add support to configure the JWT signing method

// JWTConfiguration holds all the JWT related configuration.
type JWTConfiguration struct {
        ...
	Method  string `json:"method" default:"HS256"`
}

- Test plan

tests pass

- Description for the changelog

Upgrade to jwt v4, gofrs uuid, and other deps

- A picture of a cute animal (not mandatory but encouraged)

@jrapoport jrapoport requested review from a team as code owners December 18, 2020 07:53
@mraerino mraerino added type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality and removed type: chore work needed to keep the product and development running smoothly labels Dec 18, 2020
@mraerino
Copy link
Member

@jrapoport this PR mikes a lot of different changes to fundamental parts of the repo.
while some of the changes are easy to land (e.g. dependency updates) some might need discussion or changes.

please try to scope down the surface of a single PR and submit multiple ones.

@jrapoport
Copy link
Author

I branched this off the version that moved to gorm. I will see if I can find time to make it its own PR. I have / am adding full grpc / grpc-web support, but it seems like these changes are too sweeping generally. I will keep them on my fork and spare you further PRs.

@jrapoport
Copy link
Author

I'm dropping a link here for anyone that finds this and wants to use it: https://github.com/jrapoport/gothic

it started off as a PR/ fork, but has since been completely rewritten.

@jrapoport jrapoport closed this Jul 6, 2021
@jrapoport jrapoport deleted the jwtv4 branch July 6, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants